Add support for WASM targets #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherRabotin
approved these changes
May 24, 2023
| serde_yaml = "0.9.21" | ||
| whoami = "1.3.0" | ||
| either = {version = "1.8.1", features = ["serde"]} | ||
| num = "0.4.0" | ||
| enum-iterator = "1.4.0" | ||
| rstest = "0.17.0" | ||
| getrandom = {version = "0.2", features = ["js"]} |
There was a problem hiding this comment.
What functionality does the getrandom crate add?
There was a problem hiding this comment.
It is used by the rand crate (which is a direct dependency of nyx). If we do not specify this feature flag, it cannot be compiled for WASM.
|
Hmm, I'm not sure what has happened by suddenly, parquet version |
ChristopherRabotin
added this to the Version 2.0.0-alpha: Python binding and refactor orbit determination milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
wasmtargets, specificallywasm32-unknown-unknown. This will enable integration of the crate into browser-based projects.